davidradl commented on code in PR #27278:
URL: https://github.com/apache/flink/pull/27278#discussion_r2565469598


##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/common/CommonExecTableSourceScan.java:
##########
@@ -188,13 +188,11 @@ protected Transformation<RowData> translateToPlanInternal(
                     ((DataStreamScanProvider) provider)
                             .produceDataStream(createProviderContext(config), 
env)
                             .getTransformation();
-            meta.fill(sourceTransform);

Review Comment:
   I am curious - could we add a test that has the advanced ScanProviders 
"setting names and uids on their own". I think it would be useful, if this is 
expected practise.  



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to