snuyanzin commented on code in PR #27287:
URL: https://github.com/apache/flink/pull/27287#discussion_r2577384166
##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/functions/inference/TypeInferenceOperandInference.java:
##########
@@ -81,9 +81,14 @@ public void inferOperandTypes(
false)) {
inferOperandTypesOrError(unwrapTypeFactory(callBinding),
callContext, operandTypes);
}
- } catch (ValidationException | CalciteContextException e) {
+ } catch (ValidationException e) {
// let operand checker fail
+ } catch (CalciteContextException e) {
+ throw e;
} catch (Throwable t) {
+ if (t.getCause() instanceof CalciteContextException) {
Review Comment:
After looking one more time here I was not able to find a test entering this
code
so I removed these lines, the PR should be a bit shorter now
thanks for attracting attention to these lines
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
