gguptp commented on code in PR #219:
URL:
https://github.com/apache/flink-connector-aws/pull/219#discussion_r2581241390
##########
flink-connector-aws/flink-connector-dynamodb/src/main/java/org/apache/flink/connector/dynamodb/source/config/DynamodbStreamsSourceConfigConstants.java:
##########
@@ -91,6 +94,10 @@ public enum InitialPosition {
.withDescription(
"The default idle time between non-empty
polls for DynamoDB Streams GetRecords API");
+ public static final int MAX_RETRY_ATTEMPTS_FOR_CHILD_SHARDS = 5;
+ public static final Duration CHILD_SHARD_DISCOVERY_MIN_DELAY =
Duration.ofMillis(100);
+ public static final Duration CHILD_SHARD_DISCOVERY_MAX_DELAY =
Duration.ofMillis(1000);
Review Comment:
The api might not give the child shards in the first go and might require at
max 5 retries based on our testing. Having these as customer configured values
has the chance of customers providing wrong values causing the API to never
become effective
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
