5herhom commented on code in PR #4165:
URL: https://github.com/apache/flink-cdc/pull/4165#discussion_r2591751514
##########
flink-cdc-connect/flink-cdc-source-connectors/flink-connector-mysql-cdc/src/test/java/org/apache/flink/cdc/connectors/mysql/debezium/reader/BinlogSplitReaderTest.java:
##########
@@ -786,6 +788,94 @@ void testReadBinlogFromGtidSet() throws Exception {
assertEqualsInOrder(Arrays.asList(expected), actual);
}
+ /**
+ * In a bad case, it will skip the rest records whitch causes infinite
wait for empty data. So
+ * it should has a timeout to avoid it.
Review Comment:
> Could you explain when will a 'bad case' happen?
This bad case occurred before this fix. If the code before this fix is used
to run this case, the situation will occur.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
