och5351 commented on code in PR #182:
URL:
https://github.com/apache/flink-connector-jdbc/pull/182#discussion_r2596875780
##########
flink-connector-jdbc-core/src/main/java/org/apache/flink/connector/jdbc/core/database/dialect/AbstractDialectConverter.java:
##########
@@ -173,7 +173,7 @@ protected JdbcDeserializationConverter
createInternalConverter(LogicalType type)
: TimestampData.fromTimestamp((Timestamp) val);
case CHAR:
case VARCHAR:
- return val -> StringData.fromString((String) val);
+ return val -> StringData.fromString(val.toString());
Review Comment:
Thank you for your review. :)
You are right; that code would cause a null pointer exception.
I will add a test case for null data and then request your review again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
