watsonjo737 commented on code in PR #4156:
URL: https://github.com/apache/flink-cdc/pull/4156#discussion_r2599176769
##########
flink-cdc-connect/flink-cdc-source-connectors/flink-connector-mysql-cdc/src/main/java/org/apache/flink/cdc/connectors/mysql/debezium/DebeziumUtils.java:
##########
@@ -242,12 +243,26 @@ private static Map<String, String> querySystemVariables(
return variables;
}
+ static SSLMode sslModeFor(MySqlConnectorConfig.SecureConnectionMode mode) {
+ try {
+ return mode == null ? null : SSLMode.valueOf(mode.name());
+ } catch (IllegalArgumentException e) {
+ throw new FlinkRuntimeException(
+ String.format("Invalid SecureConnectionMode provided: %s
", mode.name()), e);
+ }
+ }
+
public static BinlogOffset findBinlogOffset(
long targetMs, MySqlConnection connection, MySqlSourceConfig
mySqlSourceConfig) {
MySqlConnection.MySqlConnectionConfiguration config =
connection.connectionConfig();
BinaryLogClient client =
Review Comment:
Thanks for the review and recommendation @lvyanquan !
I have now updated this PR:
- ssl config now centralised under DebeziumUtils#createBinaryClient
- updated BinlogSplitReader and SnapshotSplitReader to use the new version
of createBinaryClient
- added sslSocketFactory config, similar to what is used in
flink-cdc/flink-cdc-connect/flink-cdc-source-connectors/flink-connector-mysql-cdc/src/main/java/io/debezium/connector/mysql/MySqlStreamingChangeEventSource.java
- updated iTest to include testing sslSocketFactory.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
