[
https://issues.apache.org/jira/browse/FLINK-5497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15823826#comment-15823826
]
ASF GitHub Bot commented on FLINK-5497:
---------------------------------------
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/3089
Thanks you for the effort to increase testing performance.
I think we have to look very closely here, because it may easily decrease
the test coverage. I think there were subtle differences between the tests
concerning reusability of result holder objects.
The hash table classes are at the core of many DataSet operations and had
subtle bugs before that we caught and fixed by massively expanding test
coverage. We must absolutely preserve that.
That being said, removing exact duplicates makes total sense - we simply
need to double check that these are in fact exact duplicates and not fuzzy
duplicates.
> remove duplicated tests
> -----------------------
>
> Key: FLINK-5497
> URL: https://issues.apache.org/jira/browse/FLINK-5497
> Project: Flink
> Issue Type: Improvement
> Components: Tests
> Reporter: Alexey Diomin
> Priority: Minor
>
> Now we have test which run the same code 4 times, every run 17+ seconds.
> Need do small refactoring and remove duplicated code.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
