wchan87 opened a new pull request, #27331:
URL: https://github.com/apache/flink/pull/27331
## What is the purpose of the change
*Currently, `CsvSchemaBuilder.set_null_value` doesn't `return self` which
breaks the builder design pattern which in turn makes the method unusable
without workaround to retrieve the private `_j_schema_builder` object to call
`setNullValue` directly. If left as-is, the current usage of the method with
respect to the builder design pattern returns something like:*
> AttributeError: 'NoneType' object has no attribute 'build'
## Brief change log
- *Added `return self` to the end of the `CsvSchemaBuilder.set_null_value`
method*
## Verifying this change
This change added tests and can be verified as follows:
- *Added unit test, `test_csv_default_null_value` and helper methods which
test empty string, `''` is treated as null (i.e., `None` in Python)*
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: no
- The serializers: no, the method as is for `CsvSchemaBuilder` won't work
properly as-is so this PR fixes it
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not applicable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
