Github user xhumanoid commented on the issue:
https://github.com/apache/flink/pull/3089
@StephanEwen
Hi, I did check more than double time
This two part of code fully equals:
```java
Tuple2<Integer, Integer> record;
final Tuple2<Integer, Integer> recordReuse = new Tuple2<>();
if (record = buildSide.next(recordReuse) != null ) { .. }
while (record = buildSide.next(record) != null ) { .. }
```
```java
Tuple2<Integer, Integer> record;
final Tuple2<Integer, Integer> recordReuse = new Tuple2<>();
if (record = buildSide.next(recordReuse) != null ) { .. }
while (record = buildSide.next(recordReuse) != null ) { .. }
```
after `if` record and recordReuse are pointing to one object.
Other point it's comment:
'This test is basically identical to the
"testSpillingHashJoinWithMassiveCollisions" test, only that the number',
but when @aljoscha did refactoring (2 years ago) he replaced record =>
recordReuse for one function (both place), but for second function replaced
only in one place.
p.s. i spent evening until unraveled this code from first commits =\
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
