RocMarshal commented on code in PR #180: URL: https://github.com/apache/flink-connector-jdbc/pull/180#discussion_r2617209374
########## flink-connector-jdbc-core/src/main/java/org/apache/flink/connector/jdbc/core/datastream/source/enumerator/JdbcSqlSplitEnumeratorBase.java: ########## @@ -1,104 +0,0 @@ -/* - * Licensed to the Apache Software Foundation (ASF) under one - * or more contributor license agreements. See the NOTICE file - * distributed with this work for additional information - * regarding copyright ownership. The ASF licenses this file - * to you under the Apache License, Version 2.0 (the - * "License"); you may not use this file except in compliance - * with the License. You may obtain a copy of the License at - * - * http://www.apache.org/licenses/LICENSE-2.0 - * - * Unless required by applicable law or agreed to in writing, software - * distributed under the License is distributed on an "AS IS" BASIS, - * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. - * See the License for the specific language governing permissions and - * limitations under the License. - */ - -package org.apache.flink.connector.jdbc.core.datastream.source.enumerator; - -import org.apache.flink.annotation.PublicEvolving; -import org.apache.flink.connector.jdbc.core.datastream.source.split.JdbcSourceSplit; - -import javax.annotation.Nonnull; -import javax.annotation.Nullable; - -import java.io.IOException; -import java.io.Serializable; -import java.util.List; -import java.util.function.Supplier; - -/** - * Base class for jdbc sql split enumerator. - * - * @param <SplitT> JDBC split type. - */ -@PublicEvolving -public abstract class JdbcSqlSplitEnumeratorBase<SplitT> implements AutoCloseable, Serializable { Review Comment: > So what is the recommendation? Keep the class and have two constructors on JdbcSource one of them deprecated? > > As you say is a little odd the use today, as constructor is only accessible by Builder and there is the only place we use it.. For example the current lineage expects an SqlTemplateSplitEnumerator not and JdbcSqlSplitEnumeratorBase.. > > I will try to rethink this.. @eskabetxe Sorry for not being able to devise a more elegant way to handle this transition. - I prefer that we should at least keep this class for a while, so that users who are already relying on it have time to migrate and adapt. - If we remove this class and its related components directly, it will certainly result in a poor experience for our users. If it must be removed, it would be best to include some release notes or documentation explaining the reasons behind this necessary change. In contrast, the impact of this change on the SQL side is negligible. Hope you have already thought of a better way to move forward. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
