gguptp commented on code in PR #223:
URL:
https://github.com/apache/flink-connector-aws/pull/223#discussion_r2620845281
##########
flink-python/setup.py:
##########
Review Comment:
same here, should we rather use:
```
in_flink_source = os.path.isfile(
"../flink-connector-aws/flink-connector-aws-kinesis-streams/src/main" +
"/java/org/apache/flink/connector/kinesis/source/KinesisStreamsSource.java")
```
as is there in the main branch?
##########
flink-python/setup.py:
##########
Review Comment:
could the failure be due to we using different connector version whereas
this file doesnt exist. Shoudl we rather use
`pyflink/datastream/connectors/kinesis.py` as is there in main branch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
