snuyanzin commented on code in PR #27347:
URL: https://github.com/apache/flink/pull/27347#discussion_r2622611435
##########
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/operations/SqlDdlToOperationConverterTest.java:
##########
@@ -1117,28 +1117,33 @@ void testAlterTable() throws Exception {
// test alter table options
checkAlterNonExistTable("alter table %s nonexistent set ('k1' = 'v1',
'K2' = 'V2')");
Operation operation =
- parse("alter table if exists cat1.db1.tb1 set ('k1' = 'v1',
'K2' = 'V2')");
+ parse(
+ "alter table if exists cat1.db1.tb1 set ('k1' = 'v1',
'k2' = 'v2', 'K2' = 'V1', 'K2' = 'V2')");
Map<String, String> expectedOptions = new HashMap<>();
expectedOptions.put("connector", "dummy");
expectedOptions.put("k", "v");
expectedOptions.put("k1", "v1");
+ expectedOptions.put("k2", "v2");
expectedOptions.put("K2", "V2");
assertAlterTableOptions(
operation,
expectedIdentifier,
expectedOptions,
- Arrays.asList(TableChange.set("k1", "v1"),
TableChange.set("K2", "V2")),
- "ALTER TABLE IF EXISTS cat1.db1.tb1\n SET 'k1' = 'v1',\n SET
'K2' = 'V2'");
+ Set.of(
Review Comment:
Here it in fact doesn't matter
probably the only place where it does matter for table changes is chain
modification for table columns since we can change positions there like put it
after or before that column which should be first declared.
Anyway changed back for now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
