RocMarshal commented on PR #27333: URL: https://github.com/apache/flink/pull/27333#issuecomment-3679010263
Thanks @ferenc-csaky - About the interfaces changing in the current PR. > So based on this, I'd suggest the naming below: > > * `LoadingWeight` -> `SchedulingLoad` (with a `getLoad()` method) > * `WeightLoadable` -> `HasSchedulingLoad` (with `getSchedulingLoad()`) Could you @zhuzhurk @1996fanrui help take a look ? thank a lot. - About change in other PR need to do: > I'm not sure I get the intent completely, but I really believe we should not make this more complex for now (I really like the > "you ain't gonna need it" principle, and the best code is the code that does not exist, cause that won't have bugs). @ferenc-csaky Thanks for the clarification. I'll make the change ASAP. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
