snuyanzin commented on code in PR #27341: URL: https://github.com/apache/flink/pull/27341#discussion_r2638026405
########## flink-end-to-end-tests/flink-end-to-end-tests-common/src/main/java/org/apache/flink/tests/util/ExternalResource.java: ########## @@ -0,0 +1,41 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.tests.util; + +/** + * Resource lifecycle interface for end-to-end tests. + * + * <p>This interface provides hooks for resource setup and cleanup, allowing resources to + * differentiate between successful and failed tests in their cleanup methods. + * + * <p>This is a JUnit5-compatible version that does not extend TestRule. + */ +public interface ExternalResource { + + /** Called before the test execution. */ + void before() throws Exception; + + /** Called after successful test execution. */ + void afterTestSuccess(); + + /** Called after failed test execution. Defaults to calling {@link #afterTestSuccess()}. */ + default void afterTestFailure() { Review Comment: This will not work... unfortunately. The issue is that in case of JUnit4 it will be called by junit if a field is annotated with `@Rule` which is not available under juni5. It means nobody will call this interface... Example of test where such failure happens `MetricsAvailabilityITCase` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
