[ 
https://issues.apache.org/jira/browse/FLINK-5480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15823977#comment-15823977
 ] 

ASF GitHub Bot commented on FLINK-5480:
---------------------------------------

Github user uce commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3117#discussion_r96227219
  
    --- Diff: 
flink-connectors/flink-connector-cassandra/src/main/java/org/apache/flink/streaming/connectors/cassandra/CassandraSink.java
 ---
    @@ -95,6 +95,28 @@ private CassandraSink(SingleOutputStreamOperator<IN> 
sink) {
        }
     
        /**
    +    * Sets an additional, user provided hash for this operator.
    +    *
    +    * <p/>
    +    * <p>The user provided hash is an alternative to the generated hashes, 
that is considered when identifying an
    +    * operator through the default hash mechanics fails (e.g. because of 
changes between Flink versions.
    +    *
    +    * <p><strong>Important</strong>: this hash needs to be unique per 
transformation and job. Otherwise, job
    +    * submission will fail.
    +    *
    +    * @param hash the user provided hash for this operator.
    +    * @return The operator with the user provided hash.
    +    */
    +   public CassandraSink<IN> provideAdditionalNodeHash(String hash) {
    --- End diff --
    
    I think the `provide` prefix gives the impression that it is possible to 
provide multiple additional node hashes. I would replcae this with `set`. What 
do you think?


> User-provided hashes for operators
> ----------------------------------
>
>                 Key: FLINK-5480
>                 URL: https://issues.apache.org/jira/browse/FLINK-5480
>             Project: Flink
>          Issue Type: Improvement
>          Components: DataStream API
>    Affects Versions: 1.2.0
>            Reporter: Stefan Richter
>            Assignee: Stefan Richter
>
> We could allow users to provided (alternative) hashes for operators in a 
> StreamGraph. This can make migration between Flink versions easier, in case 
> the automatically produced hashes between versions are incompatible. For 
> example, users could just copy the old hashes from the web ui to their job.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to