xuyangzhong commented on code in PR #26514:
URL: https://github.com/apache/flink/pull/26514#discussion_r2641873793
##########
flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/plan/nodes/physical/common/CommonPhysicalLookupJoin.scala:
##########
@@ -190,13 +191,18 @@ abstract class CommonPhysicalLookupJoin(
case t: TableSourceTable => t.contextResolvedTable.getIdentifier
case t: LegacyTableSourceTable[_] => t.tableIdentifier
}
+ val filterPushdownString: String = temporalTable match {
+ case t: TableSourceTable => getTableFilterString(t)
+ case _: LegacyTableSourceTable[_] => ""
+ }
super
.explainTerms(pw)
.item("table", tableIdentifier.asSummaryString())
Review Comment:
What about reusing this item `table` with:
```
val tableDesc: String = temporalTable match {
case t: TableSourceTable => t.getQualifiedName.asScala.mkString(", ")
case t: LegacyTableSourceTable[_] => t.tableIdentifier.asSummaryString()
}
super
.explainTerms(pw)
.item("table", tableDesc)
...
```
Although the plans for some tests may change, this will not actually affect
compatibility, and it can be aligned with the digest in
`CommonPhysicalTableSourceScan`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
