leonardBang commented on code in PR #4199:
URL: https://github.com/apache/flink-cdc/pull/4199#discussion_r2648161624
##########
flink-cdc-runtime/src/main/java/org/apache/flink/cdc/runtime/operators/transform/SchemaMetadataTransform.java:
##########
@@ -58,13 +58,17 @@ public SchemaMetadataTransform(
partitionKeys = Arrays.asList(partitionKeyArr);
}
if (!StringUtils.isNullOrWhitespaceOnly(tableOptionString)) {
- for (String tableOption : tableOptionString.split(",")) {
- String[] kv = tableOption.split("=");
+ // Use semicolon as delimiter to support multi-value options like
+ // sequence.field=jjsj,gxsj.
+ // Keep comma delimiter for backward compatibility.
+ String delimiter = tableOptionString.contains(";") ? ";" : ",";
Review Comment:
and the default value of optional transform config option
`table-options.delimiter` could be `,` for backforward compatibility
consideration.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
