dylanhz commented on code in PR #27369:
URL: https://github.com/apache/flink/pull/27369#discussion_r2650088394
##########
flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/inference/strategies/FamilyArgumentTypeStrategy.java:
##########
@@ -86,13 +86,16 @@ public Optional<DataType> inferArgumentType(
if (Objects.equals(expectedNullability, Boolean.FALSE) &&
actualType.isNullable()) {
return callContext.fail(
throwOnFailure,
- "Unsupported argument type. Expected nullable type of
family '%s' but actual type was '%s'.",
+ "Unsupported argument type. Expected NOT NULL type of
family '%s' but actual type was '%s'.",
expectedFamily,
actualType);
}
// type is part of the family
if (actualType.getTypeRoot().getFamilies().contains(expectedFamily)) {
+ if (Objects.equals(expectedNullability, Boolean.TRUE) &&
!actualType.isNullable()) {
Review Comment:
Thanks for your suggestion! I have updated the PR description. Please let me
know if you have any further feedback.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
