fresh-borzoni commented on PR #27378: URL: https://github.com/apache/flink/pull/27378#issuecomment-3706530707
[FLINK-38569](https://issues.apache.org/jira/browse/FLINK-38569) is about removing no-op `ReadingMetadataSpec` instances (`metadata=[]`), which are planner artifacts with no semantic effect, so it causes confusion. During implementation it became clear that unconditionally skipping metadata handling would regress [FLINK-23911](https://issues.apache.org/jira/browse/FLINK-23911), which relies on invoking `SupportsReadingMetadata.applyReadableMetadata(...)` even when the effective metadata set is empty, to correctly configure source output schemas. This change therefore separates these concerns: - source configuration (`applyReadableMetadata`) is preserved, including for empty metadata sets - `ReadingMetadataSpec` is created only when metadata is actually read This avoids no-op planner abilities while maintaining existing source semantics. The separation is intentional but open for discussion if this coupling is still preferred. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
