ferenc-csaky commented on code in PR #13:
URL:
https://github.com/apache/flink-connector-http/pull/13#discussion_r2665687321
##########
docs/content.zh/docs/connectors/table/http.md:
##########
@@ -520,10 +524,14 @@ Metadata columns can be specified and hold http
information. They are optional r
| HTTP_ERROR_STATUS | HTTP error status code |
| EXCEPTION | An Exception occurred |
| UNABLE_TO_DESERIALIZE_RESPONSE | Unable to deserialize HTTP response |
+| IGNORE_STATUS_CODE | Status code was ignored |
Review Comment:
nit: maybe "Status code is ignored"?
if change, same in the other doc file
##########
flink-connector-http/src/main/java/org/apache/flink/connector/http/table/lookup/HttpTableLookupFunction.java:
##########
@@ -104,9 +104,6 @@ public Collection<RowData> lookup(RowData keyRow) {
int physicalArity = -1;
GenericRowData producedRow = null;
- if (httpRowDataWrapper.shouldIgnore()) {
- return Collections.emptyList();
Review Comment:
Why is this not necessary anymore?
##########
docs/content.zh/docs/connectors/table/http.md:
##########
@@ -503,6 +503,10 @@ this means that these columns will be null for nullable
columns and hold a defau
When using `http.source.lookup.continue-on-error` as true, consider adding
extra metadata columns that will surface information about failures into your
stream.
+Note that if Metadata columns are specified and the status code is ignored,
then a row containing metadata columns will be produced. If
Review Comment:
nit: Metadata -> metadata
same in the other doc file
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
