xintongsong commented on code in PR #413:
URL: https://github.com/apache/flink-agents/pull/413#discussion_r2667670112
##########
docs/content/docs/get-started/installation.md:
##########
@@ -64,7 +64,20 @@ cp $FLINK_HOME/opt/flink-python-1.20.3.jar $FLINK_HOME/lib/
- Unix-like environment (Linux, Mac OS X, Cygwin, or WSL)
- Git
- Maven 3
- - Java 11
+ - Java 11 or 17
Review Comment:
```suggestion
- Java 17+ (full functionality), or Java 11+ (some features unavailable)
```
##########
docs/content/docs/get-started/installation.md:
##########
@@ -64,7 +64,20 @@ cp $FLINK_HOME/opt/flink-python-1.20.3.jar $FLINK_HOME/lib/
- Unix-like environment (Linux, Mac OS X, Cygwin, or WSL)
- Git
- Maven 3
- - Java 11
+ - Java 11 or 17
+
+### JDK Version Requirements (for Java API users)
+
+If you are developing Flink Agents jobs using the **Java API**, the JDK
version requirements are:
+
+| Feature | JDK Requirement | Description |
+|---------|-----------------|-------------|
+| Core Features | JDK 11+ | Agent, Tool, Prompt, ChatModel, and other basic
features |
+| MCP Support | JDK 17+ | MCP (Model Context Protocol) integration for
connecting to MCP servers |
+
+{{< hint info >}}
+**Note:** If you are using the **Python API** to develop Flink Agents jobs,
you can use JDK 11+ regardless of whether you use MCP features. The Python SDK
has its own MCP implementation.
+{{< /hint >}}
Review Comment:
```suggestion
### Java Versions
For running an agent built with **Python API**, you can use any Java version
11 or higher.
When using **Java API**, there are some functionality limitations for
earlier Java versions, as detailed below:
| Java Version | Limitations |
|---|---|
| Java 17+ | No limitations. |
| Java 11-16 | MCP supports are unavailable. |
```
##########
docs/content/docs/get-started/installation.md:
##########
@@ -64,7 +64,20 @@ cp $FLINK_HOME/opt/flink-python-1.20.3.jar $FLINK_HOME/lib/
- Unix-like environment (Linux, Mac OS X, Cygwin, or WSL)
- Git
- Maven 3
- - Java 11
+ - Java 11 or 17
+
+### JDK Version Requirements (for Java API users)
+
+If you are developing Flink Agents jobs using the **Java API**, the JDK
version requirements are:
+
+| Feature | JDK Requirement | Description |
+|---------|-----------------|-------------|
+| Core Features | JDK 11+ | Agent, Tool, Prompt, ChatModel, and other basic
features |
+| MCP Support | JDK 17+ | MCP (Model Context Protocol) integration for
connecting to MCP servers |
+
+{{< hint info >}}
+**Note:** If you are using the **Python API** to develop Flink Agents jobs,
you can use JDK 11+ regardless of whether you use MCP features. The Python SDK
has its own MCP implementation.
+{{< /hint >}}
Review Comment:
This should make it easier for adding new Java versions and limitations in
future.
##########
tools/releasing/deploy_staging_jars.sh:
##########
@@ -35,12 +35,41 @@ if [[ `basename $CURR_DIR` != "tools" ]] ; then
exit 1
fi
+# Check JDK version - must be JDK 17
+JAVA_VERSION=$(java -version 2>&1 | head -1 | cut -d'"' -f2 | cut -d'.' -f1)
+if [[ "$JAVA_VERSION" != "17" ]]; then
+ echo "Error: JDK 17 is required for release. Current version: $(java
-version 2>&1 | head -1)"
+ exit 1
+fi
+
###########################
cd ..
-echo "Deploying to repository.apache.org"
+echo "=== Flink Agents Multi-JDK Release ==="
+echo "Using Java: $(java -version 2>&1 | head -1)"
COMMON_OPTIONS="-Prelease,docs-and-source -DskipTests
-DretryFailedDeploymentCount=10 $CUSTOM_OPTIONS"
+###########################
+# Phase 1: Build and deploy default version (JDK 17)
+###########################
+
+echo ""
+echo "=== Phase 1: Building and deploying default version (JDK 17 bytecode)
==="
+echo ""
+
$MVN clean deploy $COMMON_OPTIONS
+
+###########################
+# Phase 2: Build and deploy api module with jdk11 classifier
+###########################
+
+echo ""
+echo "=== Phase 2: Building and deploying flink-agents-api with jdk11
classifier (JDK 11 bytecode) ==="
+echo ""
+
+$MVN deploy -pl api -Pjava-11-target,release,docs-and-source -DskipTests
-DretryFailedDeploymentCount=10 $CUSTOM_OPTIONS
Review Comment:
Why not reusing `COMMON_OPTIONS`? I think maven supports setting multiple
profiles like `mvn -P profile1 -P profile2`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
