davidradl commented on code in PR #12:
URL:
https://github.com/apache/flink-connector-http/pull/12#discussion_r2675920860
##########
flink-connector-http/src/main/java/org/apache/flink/connector/http/table/lookup/JavaNetHttpPollingClient.java:
##########
@@ -326,22 +327,49 @@ private Collection<RowData> deserialize(String
responseBody) throws IOException
}
}
- private List<RowData> deserializeSingleValue(byte[] rawBytes) throws
IOException {
- return Optional.ofNullable(responseBodyDecoder.deserialize(rawBytes))
- .map(Collections::singletonList)
- .orElse(Collections.emptyList());
+ @VisibleForTesting
Review Comment:
With the otehr change I agree - I will remove this tag and make the method
private
##########
flink-connector-http/src/main/java/org/apache/flink/connector/http/table/lookup/JavaNetHttpPollingClient.java:
##########
@@ -326,22 +327,49 @@ private Collection<RowData> deserialize(String
responseBody) throws IOException
}
}
- private List<RowData> deserializeSingleValue(byte[] rawBytes) throws
IOException {
- return Optional.ofNullable(responseBodyDecoder.deserialize(rawBytes))
- .map(Collections::singletonList)
- .orElse(Collections.emptyList());
+ @VisibleForTesting
Review Comment:
With the other change I agree - I will remove this tag and make the method
private
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
