davidradl commented on code in PR #27394:
URL: https://github.com/apache/flink/pull/27394#discussion_r2676137731


##########
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/internal/TableEnvironmentImpl.java:
##########
@@ -263,6 +265,19 @@ public static TableEnvironmentImpl 
create(EnvironmentSettings settings) {
                         ? settings.getCatalogStore()
                         : catalogStoreFactory.createCatalogStore();
 
+        final SecretStoreFactory secretStoreFactory =

Review Comment:
   I suggest adding a test implementation of these interfaces to drive the 
usage of the interfaces from tests, including  writeable readable stores with 
config options.  



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to