snuyanzin commented on code in PR #27401:
URL: https://github.com/apache/flink/pull/27401#discussion_r2681510601
##########
tools/ci/compile.sh:
##########
@@ -86,7 +86,7 @@ javadoc_output=/tmp/javadoc.out
# use the same invocation as .github/workflows/docs.sh
$MVN javadoc:aggregate -DadditionalJOption='-Xdoclint:none' \
-Dmaven.javadoc.failOnError=false -Dcheckstyle.skip=true
-Denforcer.skip=true -Dspotless.skip=true -Drat.skip=true \
- -Dheader=someTestHeader > ${javadoc_output}
+ -Dheader=someTestHeader -Pskip-webui-build > ${javadoc_output}
Review Comment:
don't think it is short term, there is no javadocs in web ui build, so
anyway it desn't make sense to include it while building javadoc
in case of hotfix it doesn't make sense to create a jira inho
##########
tools/ci/compile.sh:
##########
@@ -86,7 +86,7 @@ javadoc_output=/tmp/javadoc.out
# use the same invocation as .github/workflows/docs.sh
$MVN javadoc:aggregate -DadditionalJOption='-Xdoclint:none' \
-Dmaven.javadoc.failOnError=false -Dcheckstyle.skip=true
-Denforcer.skip=true -Dspotless.skip=true -Drat.skip=true \
- -Dheader=someTestHeader > ${javadoc_output}
+ -Dheader=someTestHeader -Pskip-webui-build > ${javadoc_output}
Review Comment:
don't think it is short term, there is no javadocs in web ui build, so
anyway it desn't make sense to include it while building javadoc
in case of hotfix it doesn't make sense to create a jira imho
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
