davidradl commented on code in PR #27423:
URL: https://github.com/apache/flink/pull/27423#discussion_r2697758757
##########
flink-runtime/src/main/java/org/apache/flink/runtime/state/filesystem/FsCompletedCheckpointStorageLocation.java:
##########
@@ -71,6 +71,7 @@ public void disposeStorageLocation() throws IOException {
if (fs == null) {
fs = exclusiveCheckpointDir.getFileSystem();
}
- fs.delete(exclusiveCheckpointDir, false);
+ // Recursively delete the checkpoint directory and all its contents
+ fs.delete(exclusiveCheckpointDir, true);
Review Comment:
the change looks good.
I was wondering if the deletion fails (e.g. for permissions reasons ) should
we look to catch and log that error.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
