[
https://issues.apache.org/jira/browse/FLINK-5256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15825599#comment-15825599
]
Anton Mushin edited comment on FLINK-5256 at 1/17/17 8:19 AM:
--------------------------------------------------------------
Hi,
I update PR, but it is incorrect yet.
I have some problem with {{MapJoinRightRunner}}, more accurate in debug time I
noticed what I never came to {{MapJoinRightRunner}} for any sql queries with
outer join. Does it make sense support join with null records in
{{MapJoinRightRunner}} in this case? Or it is bug and need fix it?
Also it is causes some problems. See cases
[testSingleRowRightOuterJoin|https://github.com/apache/flink/pull/3033/files#diff-102e5d9e330260c0acf5e4e54ff3bdceR419]
and
[testSingleRowRightOuterJoinWithNullRecords|https://github.com/apache/flink/pull/3033/files#diff-102e5d9e330260c0acf5e4e54ff3bdceR509]
The sql qureise on this cases is executing via only from {{MapJoinLeftRunner}}
I get not correct result
was (Author: anmu):
Hi,
I update PR, but it is incorrect yet.
I have some problem with {{MapJoinRightRunner}}, more accurate in debug time I
noticed what I never came to {{MapJoinRightRunner}} for any sql queries with
outer join. Does it make sense support join with null records in
{{MapJoinRightRunner}} in this case?
Also it is causes some problems. See cases
[testSingleRowRightOuterJoin|https://github.com/apache/flink/pull/3033/files#diff-102e5d9e330260c0acf5e4e54ff3bdceR419]
and
[testSingleRowRightOuterJoinWithNullRecords|https://github.com/apache/flink/pull/3033/files#diff-102e5d9e330260c0acf5e4e54ff3bdceR509]
The sql qureise on this cases is executing via only from {{MapJoinLeftRunner}}
I get not correct result
> Extend DataSetSingleRowJoin to support Left and Right joins
> -----------------------------------------------------------
>
> Key: FLINK-5256
> URL: https://issues.apache.org/jira/browse/FLINK-5256
> Project: Flink
> Issue Type: Improvement
> Components: Table API & SQL
> Affects Versions: 1.2.0
> Reporter: Fabian Hueske
> Assignee: Anton Mushin
>
> The {{DataSetSingleRowJoin}} is a broadcast-map join that supports arbitrary
> inner joins where one input is a single row.
> I found that Calcite translates certain subqueries into non-equi left and
> right joins with single input. These cases can be handled if the
> {{DataSetSingleRowJoin}} is extended to support outer joins on the
> non-single-row input, i.e., left joins if the right side is single input and
> vice versa.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
