snuyanzin commented on code in PR #27435:
URL: https://github.com/apache/flink/pull/27435#discussion_r2701525820


##########
flink-table/flink-table-planner/src/test/resources/restore-tests/stream-exec-calc_1/calc-current-timestamp/plan/calc-current-timestamp.json:
##########
@@ -0,0 +1,117 @@
+{
+  "flinkVersion" : "2.0",
+  "nodes" : [ {
+    "id" : 21,
+    "type" : "stream-exec-table-source-scan_1",
+    "scanTableSource" : {
+      "table" : {
+        "identifier" : "`default_catalog`.`default_database`.`t`",
+        "resolvedTable" : {
+          "schema" : {
+            "columns" : [ {
+              "name" : "a",
+              "dataType" : "BIGINT"
+            } ],
+            "watermarkSpecs" : [ ]
+          },
+          "partitionKeys" : [ ]
+        }
+      }
+    },
+    "outputType" : "ROW<`a` BIGINT>",
+    "description" : "TableSourceScan(table=[[default_catalog, 
default_database, t]], fields=[a])",
+    "inputProperties" : [ ]
+  }, {
+    "id" : 22,
+    "type" : "stream-exec-calc_1",
+    "projection" : [ {
+      "kind" : "CALL",
+      "syntax" : "BINARY",
+      "internalName" : "$/$1",
+      "operands" : [ {
+        "kind" : "CALL",
+        "internalName" : "$EXTRACT$1",
+        "operands" : [ {
+          "kind" : "LITERAL",
+          "symbol" : "TIME_UNIT_RANGE",
+          "value" : "YEAR",
+          "type" : {
+            "type" : "SYMBOL",
+            "nullable" : false
+          }
+        }, {
+          "kind" : "CALL",
+          "internalName" : "$CURRENT_TIMESTAMP$1",
+          "operands" : [ ],
+          "type" : "TIMESTAMP(3) WITH LOCAL TIME ZONE NOT NULL"

Review Comment:
   The issue is that it stopped writing syntax for time functions here (which 
before 2.0 was `FUNCTION_ID`)
   After the fix
   1. it will write `syntax` info again (for the case of `FUNCTION_ID`)
   2. it is able to read and restore job even if this info is absent in 
compiled plan



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to