xintongsong commented on code in PR #452:
URL: https://github.com/apache/flink-agents/pull/452#discussion_r2703460393
##########
api/src/main/java/org/apache/flink/agents/api/tools/Tool.java:
##########
@@ -29,12 +29,16 @@
*/
public abstract class Tool extends SerializableResource {
- protected final ToolMetadata metadata;
+ protected ToolMetadata metadata;
Review Comment:
Should not make this non-final.
##########
e2e-test/flink-agents-end-to-end-tests-resource-cross-language/src/test/java/org/apache/flink/agents/resource/test/MCPCrossLanguageAgent.java:
##########
@@ -0,0 +1,85 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.flink.agents.resource.test;
+
+import org.apache.flink.agents.api.InputEvent;
+import org.apache.flink.agents.api.OutputEvent;
+import org.apache.flink.agents.api.agents.Agent;
+import org.apache.flink.agents.api.annotation.Action;
+import org.apache.flink.agents.api.annotation.MCPServerPython;
+import org.apache.flink.agents.api.chat.messages.ChatMessage;
+import org.apache.flink.agents.api.chat.messages.MessageRole;
+import org.apache.flink.agents.api.context.RunnerContext;
+import org.apache.flink.agents.api.prompt.Prompt;
+import org.apache.flink.agents.api.resource.ResourceDescriptor;
+import org.apache.flink.agents.api.resource.ResourceType;
+import org.apache.flink.agents.api.tools.Tool;
+import org.apache.flink.agents.api.tools.ToolParameters;
+import org.apache.flink.agents.api.tools.ToolResponse;
+import org.junit.jupiter.api.Assertions;
+
+import java.util.HashMap;
+import java.util.List;
+import java.util.Map;
+
+public class MCPCrossLanguageAgent extends Agent {
+ @MCPServerPython
+ public static ResourceDescriptor pythonMCPServer() {
+ return ResourceDescriptor.Builder.newBuilder(
+
org.apache.flink.agents.plan.resource.python.PythonMCPServer.class
+ .getName())
+ .addInitialArgument("endpoint", "http://127.0.0.1:8000/mcp";)
+ .build();
+ }
Review Comment:
I think the major complexity of this PR comes from that we require returning
a `ResourceDescriptor` for python mcp servers, while for java mcp servers we
require returning a `MCPServer` object.
I think it would be better to migrate the java mcp server to also use
resource descriptor. This brings several benefits: user codes won't depend on
the integration module, and we can automatically fallback to the python mcp
server for java api users with lower jdk versions.
##########
api/src/main/java/org/apache/flink/agents/api/annotation/MCPServerPython.java:
##########
@@ -0,0 +1,34 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.agents.api.annotation;
+
+import java.lang.annotation.ElementType;
+import java.lang.annotation.Retention;
+import java.lang.annotation.RetentionPolicy;
+import java.lang.annotation.Target;
+
+/**
+ * Annotation to mark a field as a chat model resource that should be managed
by the agent plan.
+ *
+ * <p>Fields annotated with @ChatModel will be scanned during agent plan
creation and corresponding
+ * resource providers will be created to manage the chat model instances.
+ */
+@Target({ElementType.METHOD})
+@Retention(RetentionPolicy.RUNTIME)
+public @interface MCPServerPython {}
Review Comment:
Why do we need this dedicated annotation?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
