zhuzhurk commented on code in PR #27430:
URL: https://github.com/apache/flink/pull/27430#discussion_r2704456379
##########
flink-runtime-web/src/test/java/org/apache/flink/runtime/webmonitor/history/HistoryServerTest.java:
##########
@@ -130,6 +149,9 @@ void testHistoryServerIntegration(final boolean
versionLessThan14) throws Except
==
HistoryServerArchiveFetcher.ArchiveEventType.CREATED) {
numExpectedArchivedJobs.countDown();
}
+ },
+ (event) -> {
+ throw new RuntimeException("Should not called");
Review Comment:
called -> call
##########
flink-core/src/main/java/org/apache/flink/configuration/HistoryServerOptions.java:
##########
@@ -164,6 +171,52 @@ public class HistoryServerOptions {
code("IllegalConfigurationException"))
.linebreak()
.text(NOTE_MESSAGE)
+ .list(
+ text(CONFIGURE_SINGLE_INSTANCE),
+ text(CONFIGURE_CONSISTENT))
+ .linebreak()
+ .text(LEGACY_NOTE_MESSAGE)
+ .build());
+
+ /**
+ * If this option is enabled then deleted application archives are also
deleted from
+ * HistoryServer.
+ */
+ public static final ConfigOption<Boolean>
HISTORY_SERVER_CLEANUP_EXPIRED_APPLICATIONS =
+ key("historyserver.archive.clean-expired-applications")
+ .booleanType()
+ .defaultValue(false)
+ .withDescription(
+ Description.builder()
+ .text(
+ "Whether HistoryServer should
cleanup jobs that are no longer present in the archive directory defined by %s.
",
Review Comment:
jobs -> applications
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
