yuxiqian commented on code in PR #4227:
URL: https://github.com/apache/flink-cdc/pull/4227#discussion_r2704515004
##########
flink-cdc-runtime/src/main/java/org/apache/flink/cdc/runtime/parser/JaninoCompiler.java:
##########
@@ -446,6 +449,20 @@ private static Java.Rvalue generateOtherOperation(
return new Java.MethodInvocation(
Location.NOWHERE, null,
StringUtils.convertToCamelCase("CONCAT"), atoms);
}
+ if
(sqlBasicCall.getOperator().getName().equalsIgnoreCase(PARSE_JSON.getName())) {
+ return new Java.MethodInvocation(
+ Location.NOWHERE,
+ null,
+ StringUtils.convertToCamelCase(PARSE_JSON.getName()),
+ atoms);
+ }
+ if
(sqlBasicCall.getOperator().getName().equalsIgnoreCase(TRY_PARSE_JSON.getName()))
{
+ return new Java.MethodInvocation(
+ Location.NOWHERE,
+ null,
+ StringUtils.convertToCamelCase(TRY_PARSE_JSON.getName()),
+ atoms);
+ }
Review Comment:
This seems to be redundant, PARSE_JSON and TRY_PARSE_JSON are
`SqlKind.OTHER_FUNCTION` and got handled in `generateOtherFunctionOperation`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
