Savonitar commented on code in PR #58:
URL:
https://github.com/apache/flink-connector-mongodb/pull/58#discussion_r2707196393
##########
flink-connector-mongodb/src/main/java/org/apache/flink/connector/mongodb/table/MongoConnectorOptions.java:
##########
@@ -115,6 +115,18 @@ private MongoConnectorOptions() {}
.withDescription(
"Specifies the retry time interval if lookup
records from database failed.");
+ public static final ConfigOption<Boolean> SINK_ORDERED_WRITES =
+ ConfigOptions.key("sink.orderedWrites")
Review Comment:
The new configuration options use camelCase instead of kebab-case, which is
inconsistent with existing options in this connector (and also in flink):
e.g.
```
ConfigOptions.key("sink.orderedWrites")
```
Usually is (consistent with existing):
```
ConfigOptions.key("sink.ordered-writes") // kebab-case
```
Since this feature hasn't been released yet, now is the right time to fix
the naming before it becomes a breaking change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
