davidradl commented on code in PR #27447: URL: https://github.com/apache/flink/pull/27447#discussion_r2707427034
########## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/rules/logical/AsyncCalcSplitRuleTest.java: ########## Review Comment: I am a bit confused. This change was for a change to datagen as per the PR title. It looks like you have expanded this hotfix to include other documentation - is this to bring it up to date with the version 2 stream? This seems a lot for a hot fix. You have also included a lot of code - I am not sure why . It would be better to separate out these changes and have Jiras for the non-trivial changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
