davidradl commented on code in PR #27440:
URL: https://github.com/apache/flink/pull/27440#discussion_r2707573851
##########
docs/layouts/shortcodes/generated/pipeline_configuration.html:
##########
@@ -116,6 +116,12 @@
<td>List<String></td>
<td>List of pairs of class names and serializer configs to be
used. There is a <code class="highlighter-rouge">type</code> field in the
serializer config and each type has its own configuration. Note: only standard
YAML config parser is supported, please use "config.yaml" as the config file.
The fields involved are:<ul><li><code class="highlighter-rouge">type</code>:
the serializer type which could be "pojo", "kryo" or "typeinfo". If the
serializer type is "pojo" or "kryo" without field <code
class="highlighter-rouge">kryo-type</code>, it means the data type will use
POJO or Kryo serializer directly.</li><li><code
class="highlighter-rouge">kryo-type</code>: the Kryo serializer type which
could be "default" or "registered". The Kryo serializer will use the serializer
for the data type as default serializers when the kryo-type is "default", and
register the data type and its serializer to Kryo serializer when the kryo-type
is registered. When the field exists, there must
be a field <code class="highlighter-rouge">class</code> to specify the
serializer class name.</li><li><code class="highlighter-rouge">class</code>:
the serializer class name for type "kryo" or "typeinfo". For "kryo", it should
be a subclass of <code
class="highlighter-rouge">com.esotericsoftware.kryo.Serializer</code>. For
"typeinfo", it should be a subclass of <code
class="highlighter-rouge">org.apache.flink.api.common.typeinfo.TypeInfoFactory</code>.</li></ul>Example:<br
/><code class="highlighter-rouge">[org.example.ExampleClass1: {type: pojo},
org.example.ExampleClass2: {type: kryo}, org.example.ExampleClass3: {type:
kryo, kryo-type: default, class: org.example.Class3KryoSerializer},
org.example.ExampleClass4: {type: kryo, kryo-type: registered, class:
org.example.Class4KryoSerializer}, org.example.ExampleClass5: {type: typeinfo,
class: org.example.Class5TypeInfoFactory}]</code></td>
</tr>
+ <tr>
+ <td><h5>pipeline.sources.pause-until-first-checkpoint</h5></td>
+ <td style="word-wrap: break-word;">true</td>
+ <td>Boolean</td>
+ <td>Don't pull any data from sources until the first checkpoint is
triggered. This might be helpful in reducing recovery times. Incompatible 0
value for execution.checkpointing.interval-during-backlog</td>
Review Comment:
I suggest expanding on "This might be helpful in reducing recovery times."
to be specific about the scenarios that this would be helpful in. Are there
scenarios it would not be helpful in? If there are no downsides to this change
- then do we need a config option?
I am not sure what `Incompatible 0 value for
execution.checkpointing.interval-during-backlog` means .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
