dawidwys commented on code in PR #27426:
URL: https://github.com/apache/flink/pull/27426#discussion_r2708478816
##########
flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/plan/stream/sql/DeltaJoinTest.scala:
##########
@@ -150,15 +151,17 @@ class DeltaJoinTest extends TableTestBase {
"insert into snk select * from src1 join src2 " +
"on src1.a1 = src2.b1 " +
"and src1.a2 = src2.b2 " +
- "and src1.a3 = src2.b0")
+ "and src1.a3 = src2.b0 " +
+ "on conflict do deduplicate")
Review Comment:
Not sure what would be the goal. The tests without the `on conflict do
deduplicate` fail during the planning. I wanted to introduce that breaking
change so that users are steered into making conscious decision on the SUM.
This way I hope to decrease the usage of that expensive operator.
I did added tests that verify it fails if the SUM is needed, but no `ON
CONFLICT` was provided.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
