snuyanzin commented on code in PR #27445:
URL: https://github.com/apache/flink/pull/27445#discussion_r2710140754
##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/operations/converters/SqlNodeConvertUtils.java:
##########
@@ -85,7 +85,7 @@ static CatalogView toCatalogView(
context.getSqlValidator().getNamespace(validateQuery);
validateDuplicatedColumnNames(query, viewFields, validatedNamespace);
- String expandedQuery = context.toQuotedSqlString(query);
+ String expandedQuery = context.toQuotedSqlString(validateQuery);
Review Comment:
thanks for extra mile here
confirmed, on my side I reproduced this issue in pure Calcite (the weird
thing is that it is not only about `ORDER BY`, there are other cases)
agree on the changing to `validateQuery` here
may be we can/should add a comment that input `SqlNode` (in this case
`query`) shouldn't be used anymore as it might be invalid
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
