leonardBang commented on PR #212:
URL:
https://github.com/apache/flink-connector-kafka/pull/212#issuecomment-3775954183
> Is there any ITCase for table and SQL
Hi, I noticed this PR was merged without fully following our community’s
merging guidelines. Specifically:
(a) There was no PR description explaining the purpose or design of the
change.
(b) Several reviewers (including multiple committers) left unresolved
comments, yet none of them gave a formal +1.
(c) The PR still lacks an integration test (ITCase). For a new connector
like `dynamic-kafka`, we should include a Flink SQL job in the IT suite to
validate end-to-end behavior and ensure correctness.
Could you kindly resolve my concerns @bowenli86 ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
