mateczagany commented on code in PR #27457:
URL: https://github.com/apache/flink/pull/27457#discussion_r2716047585
##########
flink-core/src/main/java/org/apache/flink/configuration/SecurityOptions.java:
##########
@@ -514,15 +523,6 @@ public static Configuration forProvider(Configuration
configuration, String prov
"here"))
.build());
- /** Flag to enable/disable hostname verification for the ssl connections.
*/
- @Documentation.Section(Documentation.Sections.SECURITY_SSL)
- public static final ConfigOption<Boolean> SSL_VERIFY_HOSTNAME =
Review Comment:
Thank you for reviewing this PR, I've tried to explain this as best as I
could in the description of the PR. This configuration was not used before the
mentioned PR merged yesterday. However in the ML discussion it's clear that the
implementation in that PR is wrong, and we should not have hostname
verification for internal communication.
There will be a migration guide probably in the release blog post that this
configuration was not working properly in any other recent release, and that
users should use the new configuration.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
