davidradl commented on code in PR #27453:
URL: https://github.com/apache/flink/pull/27453#discussion_r2716098444
##########
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/nodes/exec/serde/RexNodeJsonSerdeTest.java:
##########
@@ -977,6 +1003,24 @@ public void eval(CompletableFuture<String> res, Integer
i) {
}
}
+ /** Serializable process table function. */
+ public static class SerializableProcessTableFunction extends
ProcessTableFunction<String> {
Review Comment:
The code seems good. I am curious about the name of this class. It is
possible to have a non serializable PTF? If not, I suggest naming this
something like `MyProcessTableFunction` to prevent confusion. If we can
reasonably have a non serializable PTF, we should have a test for this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
