davidradl commented on code in PR #27458:
URL: https://github.com/apache/flink/pull/27458#discussion_r2716264306
##########
flink-python/pyflink/fn_execution/__init__.py:
##########
@@ -16,10 +16,15 @@
# limitations under the License.
################################################################################
+import logging
import os
+_LOG = logging.getLogger(__name__)
+
if 'PYFLINK_CYTHON_ENABLED' in os.environ:
PYFLINK_CYTHON_ENABLED = bool(os.environ['PYFLINK_CYTHON_ENABLED'])
+ if not PYFLINK_CYTHON_ENABLED:
+ _LOG.info("PYFLINK_CYTHON_ENABLED is set to False via environment
variable.")
else:
PYFLINK_CYTHON_ENABLED = True
Review Comment:
does this mean that if the environment variable is not specified we set it
to True. If we want True to be the default, then would it not be clearer to set
it to True prior to the if.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
