fapaul commented on code in PR #213:
URL:
https://github.com/apache/flink-connector-kafka/pull/213#discussion_r2716783936
##########
flink-connector-kafka-e2e-tests/flink-end-to-end-tests-common-kafka/src/test/java/org/apache/flink/tests/util/kafka/SQLClientSchemaRegistryITCase.java:
##########
@@ -54,40 +55,40 @@
import java.util.concurrent.TimeUnit;
import static org.hamcrest.CoreMatchers.equalTo;
-import static org.junit.Assert.assertThat;
+import static org.hamcrest.MatcherAssert.assertThat;
Review Comment:
Let's not introduce new hamcrest but rather use assertj
##########
flink-connector-kafka-e2e-tests/flink-end-to-end-tests-common-kafka/src/test/java/org/apache/flink/tests/util/kafka/KafkaSinkE2ECase.java:
##########
@@ -50,13 +50,15 @@ public class KafkaSinkE2ECase extends
SinkTestSuiteBase<String> {
// Defines TestEnvironment
@TestEnv FlinkContainerTestEnvironment flink = new
FlinkContainerTestEnvironment(1, 6);
+ private final TestKafkaContainer kafkaContainer =
+ new
TestKafkaContainer(DockerImageVersions.KAFKA).withNetworkAliases(KAFKA_HOSTNAME);
+
// Defines ConnectorExternalSystem
+ @SuppressWarnings({"rawtypes", "unchecked"})
@TestExternalSystem
- DefaultContainerizedExternalSystem<KafkaContainer> kafka =
+ DefaultContainerizedExternalSystem kafka =
Review Comment:
Why are we using the RawType here, can't we use some kind of
superclass/interface?
##########
flink-connector-kafka-e2e-tests/flink-end-to-end-tests-common-kafka/src/test/java/org/apache/flink/tests/util/kafka/KafkaSourceE2ECase.java:
##########
@@ -48,13 +48,15 @@ public class KafkaSourceE2ECase extends
SourceTestSuiteBase<String> {
// Defines TestEnvironment
@TestEnv FlinkContainerTestEnvironment flink = new
FlinkContainerTestEnvironment(1, 6);
+ TestKafkaContainer kafkaContainer =
+ new TestKafkaContainer(KAFKA).withNetworkAliases(KAFKA_HOSTNAME);
+
// Defines ConnectorExternalSystem
+ @SuppressWarnings({"rawtypes", "unchecked"})
Review Comment:
Same question about the raw types
##########
flink-connector-kafka-e2e-tests/flink-end-to-end-tests-common-kafka/src/test/java/org/apache/flink/tests/util/kafka/SQLClientSchemaRegistryITCase.java:
##########
@@ -54,40 +55,40 @@
import java.util.concurrent.TimeUnit;
import static org.hamcrest.CoreMatchers.equalTo;
-import static org.junit.Assert.assertThat;
+import static org.hamcrest.MatcherAssert.assertThat;
/** End-to-end test for SQL client using Avro Confluent Registry format. */
-public class SQLClientSchemaRegistryITCase {
+@Testcontainers
+@Timeout(value = 10, unit = TimeUnit.MINUTES)
Review Comment:
I am not a fan of these manual timeouts. in Flink usually there is a
watchdog tasks that collects thread dumps in case the tests starts hanging.
With this manual timeout it's to debug why the test has failed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
