snuyanzin commented on code in PR #27461:
URL: https://github.com/apache/flink/pull/27461#discussion_r2719832757
##########
flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/calcite/SqlRewriterUtils.scala:
##########
@@ -79,38 +76,6 @@ class SqlRewriterUtils(validator: FlinkCalciteSqlValidator) {
targetPosition,
unsupportedErrorMessage)
}
-
- // This code snippet is copied from the SqlValidatorImpl.
- def maybeCast(
Review Comment:
instead having old copy reuse the actual version of that method
##########
flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/calcite/SqlRewriterUtils.scala:
##########
@@ -79,38 +76,6 @@ class SqlRewriterUtils(validator: FlinkCalciteSqlValidator) {
targetPosition,
unsupportedErrorMessage)
}
-
- // This code snippet is copied from the SqlValidatorImpl.
- def maybeCast(
Review Comment:
instead of having old copy reuse the actual version of that method
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
