xintongsong commented on code in PR #468:
URL: https://github.com/apache/flink-agents/pull/468#discussion_r2719900944
##########
docs/content/docs/development/chat_models.md:
##########
@@ -235,24 +235,44 @@ Model availability and specifications may change. Always
check the official Azur
Anthropic provides cloud-based chat models featuring the Claude family, known
for their strong reasoning, coding, and safety capabilities.
-{{< hint info >}}
-Anthropic is only supported in Python currently. To use Anthropic from Java
agents, see [Using Cross-Language Providers](#using-cross-language-providers).
-{{< /hint >}}
-
#### Prerequisites
-1. Get an API key from [Anthropic Console](https://console.anthropic.com/)
+1. Create an account at [Anthropic Console](https://console.anthropic.com/)
+2. Navigate to [API Keys](https://console.anthropic.com/settings/keys) and
create a new secret key
+3. Set the API key as an environment variable: `export
ANTHROPIC_API_KEY=your-api-key`
Review Comment:
This only works when running Flink locally, but will not work when running
the job in a remote, distributed Flink cluster. This is same for OpenAI, sorry
I just realized this.
There are several ways to securely passing passwords/keys into Flink, e.g.,
via an K8s secrets. I'd suggest not discuss this in detail here, and just use
`<your-api-key>` in the doc.
##########
docs/content/docs/development/chat_models.md:
##########
@@ -235,24 +235,44 @@ Model availability and specifications may change. Always
check the official Azur
Anthropic provides cloud-based chat models featuring the Claude family, known
for their strong reasoning, coding, and safety capabilities.
-{{< hint info >}}
-Anthropic is only supported in Python currently. To use Anthropic from Java
agents, see [Using Cross-Language Providers](#using-cross-language-providers).
-{{< /hint >}}
-
#### Prerequisites
-1. Get an API key from [Anthropic Console](https://console.anthropic.com/)
+1. Create an account at [Anthropic Console](https://console.anthropic.com/)
+2. Navigate to [API Keys](https://console.anthropic.com/settings/keys) and
create a new secret key
+3. Set the API key as an environment variable: `export
ANTHROPIC_API_KEY=your-api-key`
#### AnthropicChatModelConnection Parameters
+{{< tabs "AnthropicChatModelConnection Parameters" >}}
+
+{{< tab "Python" >}}
+
| Parameter | Type | Default | Description |
|-----------|------|---------|-------------|
-| `api_key` | str | Required | Anthropic API key for authentication |
+| `api_key` | str | `$ANTHROPIC_API_KEY` | Anthropic API key for
authentication |
Review Comment:
Le't keep using `Required`, indicating that there's no default value and
users are required to explicitly set this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
