mxm commented on code in PR #27404:
URL: https://github.com/apache/flink/pull/27404#discussion_r2720479561


##########
flink-runtime/src/main/java/org/apache/flink/runtime/jobgraph/IntermediateDataSet.java:
##########
@@ -146,6 +146,11 @@ public void updateOutputPattern(
         this.isForward = isForward;
     }
 
+    public void forceUpdate(boolean isForward, DistributionPattern 
distributionPattern) {

Review Comment:
   Same here. Change the name to something like updateDistributionPattern.



##########
flink-runtime/src/main/java/org/apache/flink/runtime/jobgraph/JobEdge.java:
##########
@@ -111,6 +111,20 @@ public JobEdge(
         this.intraInputKeyCorrelated = intraInputKeyCorrelated;
     }
 
+    public void forceUpdate(

Review Comment:
   Can we change the name to make this easier to understand?
   
   ```suggestion
       public void updateDistributionPattern(
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to