davidradl commented on code in PR #27464:
URL: https://github.com/apache/flink/pull/27464#discussion_r2720723057
##########
flink-runtime-web/web-dashboard/src/app/components/job-list/job-list.component.html:
##########
@@ -28,9 +28,11 @@
<thead>
<tr>
<th [nzSortFn]="sortJobNameFn" nzWidth="40%">Job Name</th>
- <th [nzSortFn]="sortStartTimeFn">Start Time</th>
+ <th [nzSortFn]="sortStartTimeFn" [nzSortOrder]="completed ? null :
'descend'">
Review Comment:
this makes sense. A couple of thoughs :
- if we are going to default jobs to a sort order ,then does it maker sense
to additionally ask the server for a sorted list of completed and uncompleted
jobs? So it comes back in the expected default order.
- does this have a big performance impact for a large framework - if there
is one this would be a good test to add. I assume we do not paginate.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
