xintongsong commented on code in PR #470:
URL: https://github.com/apache/flink-agents/pull/470#discussion_r2723663495
##########
docs/content/docs/development/vector_stores.md:
##########
@@ -470,14 +613,84 @@ class MyVectorStore(BaseVectorStore):
# Return vector store-specific configuration
# These parameters are merged with query-specific parameters
return {"index": "my_index", ...}
-
+
+ @override
+ def size(self, collection_name: str | None = None) -> int:
+ """Get the size of the collection in vector store.
+
+ Args:
+ collection_name: The target collection. If not provided, use
defualt collection.
+ """
Review Comment:
This code snippet is an example of `MyVectorStore` that implements
`BaseVectorStore`. It's not an interface declaration. In that sense,
implementation should be provided for all these methods.
The implementation can be a simple demonstration, like:
```
def size(self, ...):
size = ...
return size
```
or
```
def delete(self, ...):
// delete the document
pass
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
