xintongsong commented on PR #472: URL: https://github.com/apache/flink-agents/pull/472#issuecomment-3793958361
This might be more like a personal opinion, but I'd prefer `ResourceName.ChatModel.ANTHROPIC_CONNECTION` over `ResourceName.ChatModel.Anthropic.CONNECTION`. Imagine typing this in an IDE, when you type `ANT`, you'll see a list of only two options `ANTHROPIC_CONNECTION` and `ANTHROPIC_SETUP`, and you can easily select between them. Having to first select `Anthropic`, then type another dot to show the list of `CONNECTION` and `SETUP` just makes things more complicate. On the other hand, without this change, when you type `OLL`, you'll see a list of `OLLAMA_CHAT_MODEL_CONNECTION`, `OLLAMA_CHAT_MODEL_SETUP`, `OLLAMA_EMBEDDING_MODEL_CONNECTION`, `OLLAMA_EMBEDDING_MODEL_SETUP` and potentially more if we support more resource types in future. First narrowing down to `ChatModel` should be helpful significantly reduce the options in the list. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
