noorall commented on code in PR #27211:
URL: https://github.com/apache/flink/pull/27211#discussion_r2727196501
##########
flink-runtime/src/test/java/org/apache/flink/runtime/rpc/RpcEndpointTest.java:
##########
@@ -472,6 +474,32 @@ void testCallAsyncTimeout() throws InterruptedException,
ExecutionException, Tim
}
}
+ /** Test schedule task when the RPC is running. */
+ @Test
+ public void testScheduleTaskAfterStart() throws Exception {
Review Comment:
`public void testScheduleTaskAfterStart()` -> `void
testScheduleTaskAfterStart()`
##########
flink-runtime/src/test/java/org/apache/flink/runtime/rpc/RpcEndpointTest.java:
##########
@@ -40,6 +40,8 @@
import static org.assertj.core.api.Assertions.assertThat;
import static org.assertj.core.api.Assertions.assertThatThrownBy;
+import static org.junit.jupiter.api.Assertions.assertFalse;
Review Comment:
ditto
##########
flink-runtime/src/test/java/org/apache/flink/runtime/blocklist/DefaultBlocklistHandlerTest.java:
##########
@@ -44,6 +44,7 @@
import static org.apache.flink.util.Preconditions.checkNotNull;
import static org.assertj.core.api.Assertions.assertThat;
+import static org.junit.jupiter.api.Assertions.assertThrows;
Review Comment:
You should use JUnit 5 instead of JUnit 4.
Example:
If you see import org.junit.jupiter.api.*, that means it's JUnit 5.
If you see import org.junit.*, that means it's JUnit 4.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
