lvyanquan commented on code in PR #4170:
URL: https://github.com/apache/flink-cdc/pull/4170#discussion_r2731584758
##########
flink-cdc-connect/flink-cdc-source-connectors/flink-connector-mysql-cdc/src/main/java/org/apache/flink/cdc/connectors/mysql/source/config/MySqlSourceConfigFactory.java:
##########
@@ -366,6 +374,9 @@ public MySqlSourceConfig createConfig(int subtaskId, String
serverName) {
// Note: the includeSchemaChanges parameter is used to control
emitting the schema record,
// only DataStream API program need to emit the schema record, the
Table API need not
props.setProperty("include.schema.changes", String.valueOf(true));
+ // enable transaction metadata if includeTransactionMetadataEvents is
true
+ props.setProperty(
+ "provide.transaction.metadata",
String.valueOf(includeTransactionMetadataEvents));
Review Comment:
nit:
Please reference the original variable name to facilitate tracking.
```
props.setProperty(CommonConnectorConfig.PROVIDE_TRANSACTION_METADATA.name(),
String.valueOf(includeTransactionMetadataEvents));
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
