snuyanzin commented on code in PR #27055:
URL: https://github.com/apache/flink/pull/27055#discussion_r2738637564
##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/rules/logical/RemoveUnreachableCoalesceArgumentsRule.java:
##########
@@ -121,6 +130,57 @@ private int getFirstNonNullableArgumentIndex(RexCall call)
{
}
return -1;
}
+
+ private RexNode convertToCaseWhen(RexCall call) {
+ List<RexNode> operands = call.operands;
+
+ if (operands.size() == 1) {
+ return operands.get(0);
+ }
Review Comment:
since convert to case when is behine is function check
shouldn't this
```java
if (operands.size() == 1) {
return operands.get(0);
}
```
be before
```java
if (containsFunctionCalls(call)) {
...
}
```
?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
