bvarghese1 commented on code in PR #27487:
URL: https://github.com/apache/flink/pull/27487#discussion_r2742700980
##########
flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/operators/over/AbstractNonTimeUnboundedPrecedingOver.java:
##########
@@ -288,6 +284,19 @@ public void processElement(
}
// Reset acc state since we can have out of order inserts in the
ordered list
+ resetAndCleanupAggFuncs();
+ }
+
+ @Override
+ public void onTimer(long timestamp, OnTimerContext ctx, Collector<RowData>
out)
+ throws Exception {
+ if (stateCleaningEnabled) {
+ cleanupState(idState, valueMapState, accMapState, sortedListState);
+ resetAndCleanupAggFuncs();
Review Comment:
Agreed, make sense! Added.
##########
flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/operators/over/AbstractNonTimeUnboundedPrecedingOver.java:
##########
Review Comment:
Removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
